Remove unneeded non-mastodon steps. #5

2018-08-23T20:28:30Z

dracos commented

2018-08-23 20:28:30 +00:00

(Migrated from github.com)

This is more of a questioning PR - I wasn't sure that the playbook should be performing these steps at the start; I have already set up my server with a locale/timezone that I want, and nothing in the installation says it has to be UTC (might have missed something!). I also didn't see why aptitude etc was being installed. But happy to keep these on my fork if there's a reason for this.

packetbiral (Migrated from github.com) requested changes 2018-08-24 01:15:17 +00:00

roles/common/tasks/main.yml

						
				@ -16,2 +4,2 @@

				  notify:

				  - restart rsyslog

				- name: Install required ansible things

				  shell: apt-get update && apt-get -y install python-apt apt-transport-https git sudo

packetbiral (Migrated from github.com) commented

2018-08-23 22:51:00 +00:00

This bit I think is worth leaving in to prevent a situation where the needed dependencies for the Ansible apt module are missing.

Should be python-apt and python3-apt at this point, aptitude can be safely removed.

https://docs.ansible.com/ansible/latest/modules/apt_module.html

This bit I think is worth leaving in to prevent a situation where the needed dependencies for the Ansible apt module are missing. Should be python-apt and python3-apt at this point, aptitude can be safely removed. https://docs.ansible.com/ansible/latest/modules/apt_module.html

dracos (Migrated from github.com) reviewed 2018-08-24 06:51:46 +00:00

roles/common/tasks/main.yml

						
				@ -16,2 +4,2 @@

				  notify:

				  - restart rsyslog

				- name: Install required ansible things

				  shell: apt-get update && apt-get -y install python-apt apt-transport-https git sudo

dracos (Migrated from github.com) commented

2018-08-24 06:51:46 +00:00

Ah, good point. I think you only need python-apt, as the system packages all use python2 (the ansible PPA too) and the installation guide note on https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html says "By default, Ansible uses the python interpreter located at /usr/bin/python to run its modules." I'll also add git and sudo as well. Done.