Remove unneeded non-mastodon steps. #5

Merged
dracos merged 1 commits from question-beginning into master 2018-08-24 14:06:23 +00:00
2 changed files with 2 additions and 16 deletions

View File

@ -1,2 +0,0 @@
- name: restart rsyslog
service: name=rsyslog state=restarted

View File

@ -1,20 +1,8 @@
--- ---
# This role installs packages that every Mastodon server needs and does common # This role installs packages that every Mastodon server needs and does common
# node setup # node setup
- name: Install python-apt, aptitude, and debconf-utils - name: Install required ansible things
shell: apt-get update && apt-get -y install python-apt aptitude debconf-utils shell: apt-get update && apt-get -y install python-apt apt-transport-https git sudo
packetbiral commented 2018-08-23 22:51:00 +00:00 (Migrated from github.com)
Review

This bit I think is worth leaving in to prevent a situation where the needed dependencies for the Ansible apt module are missing.

Should be python-apt and python3-apt at this point, aptitude can be safely removed.

https://docs.ansible.com/ansible/latest/modules/apt_module.html

This bit I think is worth leaving in to prevent a situation where the needed dependencies for the Ansible apt module are missing. Should be python-apt and python3-apt at this point, aptitude can be safely removed. https://docs.ansible.com/ansible/latest/modules/apt_module.html
dracos commented 2018-08-24 06:51:46 +00:00 (Migrated from github.com)
Review

Ah, good point. I think you only need python-apt, as the system packages all use python2 (the ansible PPA too) and the installation guide note on https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html says "By default, Ansible uses the python interpreter located at /usr/bin/python to run its modules." I'll also add git and sudo as well. Done.

Ah, good point. I think you only need python-apt, as the system packages all use python2 (the ansible PPA too) and the installation guide note on https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html says "By default, Ansible uses the python interpreter located at /usr/bin/python to run its modules." I'll also add git and sudo as well. Done.
- name: Do any package upgrades
apt: upgrade=dist
- name: Set default locale to en_US.UTF-8
debconf: name=locales question='locales/default_environment_locale' value=en_US.UTF-8 vtype='select'
- name: Generate locales
debconf: name=locales question='locales/locales_to_be_generated' value='en_US.UTF-8 UTF-8' vtype='multiselect'
- name: Set timezone area
debconf: name=tzdata question='tzdata/Areas' value='Etc' vtype='select'
- name: Set timezone
debconf: name=tzdata question='tzdata/Zones/Etc' value='UTC' vtype='select'
notify:
- restart rsyslog
- name: Add Nodesource apt key - name: Add Nodesource apt key
apt_key: url="https://deb.nodesource.com/gpgkey/nodesource.gpg.key" state=present apt_key: url="https://deb.nodesource.com/gpgkey/nodesource.gpg.key" state=present
- name: Add Nodesource apt repositories - name: Add Nodesource apt repositories